Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] add dummy lora attention processors to prevent failures in other libs #8777

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Related to #8771.

@vladmandic would something like this work for you?

@sayakpaul sayakpaul requested a review from yiyixuxu July 3, 2024 03:33
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
should we open an issue in optimum too?

@sayakpaul
Copy link
Member Author

Cc: @JingyaHuang from the Optimum team here.

@sayakpaul sayakpaul merged commit 06ee4db into main Jul 3, 2024
17 of 18 checks passed
@sayakpaul sayakpaul deleted the dummy-lora-processors branch July 3, 2024 07:42
@vladmandic
Copy link
Contributor

thanks @sayakpaul, this looks like a valid workaround until all required pieces get updated.

@JingyaHuang
Copy link
Contributor

Thanks @sayakpaul for the heads up. If I understand correctly we once applied override_diffusers_2_0_attn_processors to avoid some issues occurred during the export to onnx, which might not be necessary anymore. Will check and if so submit a PR to deprecate it, then we should have no prob with removed lora processors.

cc. @echarlaix

@sayakpaul
Copy link
Member Author

Alright. Feel free to holler if you need anything done from our end.

sayakpaul added a commit that referenced this pull request Dec 23, 2024
…her libs (#8777)

add dummy lora attention processors to prevent failures in other libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants