add sentencepiece as a soft dependency #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Aug 3, 2024
| @@ -12,6 +12,7 @@ | |||
| is_note_seq_available, | |||
| is_onnx_available, | |||
| is_scipy_available, | |||
| is_sentencepiece_available, | |||
There was a problem hiding this comment.
Actually sentencepiece is needed by all the pipelines that need T5. Should we add them here as well?
There was a problem hiding this comment.
technically, they can use these pipelines without t5, no? i.e. use pre-computed text embeddings
| EulerDiscreteScheduler, | ||
| KolorsPipeline, | ||
| UNet2DConditionModel, | ||
| ) | ||
| from diffusers.pipelines.kolors import ChatGLMModel, ChatGLMTokenizer |
There was a problem hiding this comment.
I think we already install sentencepiece for tests. So should be good:
Line 126 in b1f43d7
There was a problem hiding this comment.
yeah, that was the main reason I didn't catch this
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* add sentencepiece as soft dependency for kolors * up --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9034