-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PAG Support for Stable Diffusion Inpaint Pipeline #9386
Conversation
Merging upstream
Hi @yiyixuxu @a-r-r-o-w, following up in case you missed this, let me know if there is anything I can do to speed up this process |
Hi, can you please resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! very nice!
I left some small feedbacks!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the quality tests using make quality
? Could you also add this pipeline to the PAG docs: https://github.com/huggingface/diffusers/blob/main/docs/source/en/api/pipelines/pag.md
I think CI still not passing |
I've ran it and made the change, hopefully it passes now |
@@ -55,7 +57,6 @@ | |||
from .pipeline_pag_sd import StableDiffusionPAGPipeline | |||
from .pipeline_pag_sd_3 import StableDiffusion3PAGPipeline | |||
from .pipeline_pag_sd_animatediff import AnimateDiffPAGPipeline | |||
from .pipeline_pag_sd_img2img import StableDiffusionPAGImg2ImgPipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a merge conflict? can yo uadd this line back?
@@ -55,7 +57,6 @@ | |||
from .pipeline_pag_sd import StableDiffusionPAGPipeline | |||
from .pipeline_pag_sd_3 import StableDiffusion3PAGPipeline | |||
from .pipeline_pag_sd_animatediff import AnimateDiffPAGPipeline | |||
from .pipeline_pag_sd_img2img import StableDiffusionPAGImg2ImgPipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to add pag sd inpaint here too -currently CI fail for some import error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I'm still seeing an import error https://github.com/huggingface/diffusers/actions/runs/11266431877/job/31368980510?pr=9386#step:5:250 |
Not sure why there is an import error, I'm able to test the script through Colab |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
can anyone help look into the import error here? |
Can I please contribute to fixing the import errors? cc: @yiyixuxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make fix-copies
(after suggested change) should resolve the dependency issue
@hlky feel free to merge if it looks good to you! |
* using sd inpaint pipeline and sdxl pag inpaint pipeline to add changes * using sd inpaint pipeline and sdxl pag inpaint pipeline to add changes * finished the call function * added auto pipeline * merging diffusers * ready to test * ready to test * added copied from and removed unnecessary tests * make style changes * doc changes * updating example doc string * style fix * init * adding imports * quality * Update src/diffusers/pipelines/pag/pipeline_pag_sd_inpaint.py * make * Update tests/pipelines/pag/test_pag_sd_inpaint.py * slice and size * slice --------- Co-authored-by: Darshil Jariwala <[email protected]> Co-authored-by: Darshil Jariwala <[email protected]> Co-authored-by: YiYi Xu <[email protected]> Co-authored-by: hlky <[email protected]>
What does this PR do?
Fixes #8710 Partially
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yiyixuxu
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Hi, I have written the code and added the relevant tests and ran them, they failed in 3 cases, attached below, I'll need some assistance to test the code using images as I am GPU poor