Support bfloat16 for Upsample2D #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Sep 20, 2024
|
@sayakpaul For sure, just added a test for bfloat16 by copying over |
sayakpaul
reviewed
Sep 20, 2024
sayakpaul
reviewed
Sep 20, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@yiyixuxu is this good to merge? |
yiyixuxu
approved these changes
Sep 25, 2024
|
can we run |
|
@yiyixuxu Fixed the style in the latest commit! |
|
@yiyixuxu @sayakpaul Is there anything else I can do here to help? |
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
* Support bfloat16 for Upsample2D * Add test and use is_torch_version * Resolve comments and add decorator * Simplify require_torch_version_greater_equal decorator * Run make style --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: YiYi Xu <[email protected]>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* Support bfloat16 for Upsample2D * Add test and use is_torch_version * Resolve comments and add decorator * Simplify require_torch_version_greater_equal decorator * Run make style --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: YiYi Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support bfloat16 for Upsample2D. This change is backwards compatible.
Resolves the TODO comment as PyTorch 2.1+ supports bloat16. Referencing the original PyTorch issue:
pytorch/pytorch#86679 (comment)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
CC: @sayakpaul @yiyixuxu