-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Schedulers] Add beta sigmas / beta noise schedule #9509
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a feedback! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
we need |
I've applied |
Add beta sigmas / beta noise schedule
Add beta sigmas / beta noise schedule
What does this PR do?
This PR adds beta sigmas from Beta Sampling is All You Need. Added only to Euler for now, after initial review we will add it to other schedulers. Documentation will be updated for this scheduler and any others implemented in a subsequent PR after the initial review and after they've been added to other schedulers.
The implementation is quite simple, we add
use_beta_sigmas
parameter and_convert_to_beta
function.Beta sigmas depends on
scipy
so we add a check withis_scipy_available()
.The check for
self.config.use_exponential_sigmas and self.config.use_karras_sigmas
is moved to schedule instantiation and changed to usesum([self.config.use_beta_sigmas, self.config.use_exponential_sigmas, self.config.use_karras_sigmas]) > 1
, any future noise schedules can be added to the list to ensure only one can be selected.As a note for reviewers:
alpha
andbeta
in_convert_to_beta
are set to the default values used by Forge, should we make these configurable so we can set e.g.beta_sigmas_alpha=1.0
,beta_sigmas_beta=1.0
? I don't know how common it is to change these values. This is also relevant to futurepolyexponential
sigmas,polyexponential
produces the same asexponential
unless therho
value is changed, again I don't know how common it is to change this value, if we're not going to make the values configurable we don't need to addpolyexponential
. However it would be nice to have 1:1 compatibility with the webuis.Example usage:
Note that we set
timestep_spacing="linspace"
in addition touse_beta_sigmas=True
, this is because XL's scheduler config usestimestep_spacing="leading"
by default and the intent is to match results from the webuis where these noise schedules are currently used. We may wish to overridetimestep_spacing
tolinspace
whenuse_beta_sigmas=True
or add a warning.Tested against Forge (note that
cuda
device for generator is essential to match Forge results):and with the same settings on Forge we get the same result:
The output is similar yet better than exponential #9499 note the shape of Kirby's feet and the planets.
Both beta and exponential are better than the default noise schedule with XL:
#9490
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @asomoza @yiyixuxu