-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cogvideox autoencoder decode #9569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, this looks correct!
The commit was to resolve the merge conflict with the following |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@a-r-r-o-w could we have caught it with some tests? Or not really? In the former case, let's also add a test? |
Previously, we did not need to decode 1-frame video so this was not required, so testing for this case was not necessary. For Image-to-Video training, however, we need to be able to encode single frames (which is already supported). I think having decode work for a single frame is good to have too, since it could help with debugging. |
Cool. If you want to feel free to support a test. |
thank you, the support of image decode is useful for image-video mix tasks and further research, and this was my first pr to huggingface, hope it could merge. :) |
thanks for your PR!! @Xiang-cd |
Co-authored-by: Aryan <[email protected]>
Co-authored-by: Aryan <[email protected]>
What does this PR do?
fix bug of #9568
Fixes # (issue)
it is a simple fix with a line code change.
cogvideox train with mixsure of image and video, so the vae must support reconstruction of image, I fix the image case.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
any one who familiar with vae.
@sayakpaul @DN6 @yiyixuxu
Core library:
Integrations:
HF projects:
-->