-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distill trainer #166
Distill trainer #166
Conversation
orenpereg
commented
Nov 9, 2022
- Added Trainer for setfit distillation (file src/setfit/trainer_distill.py)
- updated fewshot_distillation script to work with DistilSetFitTrainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this nice feature @orenpereg 🔥 !
I've left a few comments / questions and would love to see some unit tests in a test_trainer_distillation.py
file (you can take inspiration from the existing SetFitTrainer
ones)
Could you also share a code snippet of how this trainer works end-to-end? I know we have that logic in the script, but it would be great to have a condensed version we can later add to the README :)
Hi @lewtun. Thanks for your thorough review and good comments🔥. I addressed all your comments and added tests under tests/test_trainer_distillation.py. can you pls take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this feature @orenpereg and adding some nice tests ❤️ !
I've left some final nits and then this should be good to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the last round of changes @orenpereg - this looks really nice 🔥
thanks Lewis :) |