Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed spell errors in code example #210

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

Gladiator07
Copy link
Contributor

Fixed spell errors of contrastive in the code examples

Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you perhaps include this typo in this PR as well?
https://github.com/huggingface/setfit/blob/main/scripts/setfit/run_fewshot_distillation.py#L231

Looks good otherwise!

@Gladiator07
Copy link
Contributor Author

Hi @tomaarsen, did the changes.

Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @Gladiator07 !

@lewtun lewtun merged commit 6471bc7 into huggingface:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants