Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker images for tokenizers main branch #16708

Closed
wants to merge 1 commit into from

Conversation

LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Apr 11, 2022

⚠️ Do not merge this PR!

PR 1/2: in order to run the full test suite (slow tests included), with the main branch of the tokenizers library, rebase this PR on main. Once the workflows have finished, head to PR 2/2 here: #16712


This PR is one of two items to run the full test suite for the tokenizers current main branch.

In order to re-run, rebuild the docker images, publish them to the docker hub, and rebase this PR on the main branch of this repository.

Steps done in order to create this PR:

  • Edit the dockerfiles so that they successfully install tokenizers from source in the container
  • Edit the build-docker-images.yml action to:
    • Have it push these images to the Docker Hub.
    • Remove all non important images
    • Edit the identifier to contain internal as a prefix, and tokenizers-main as a suffix.
  • Convert these images to private visibility so that it does not surprise users

These images will be built on each commit, so rebasing this branch on main will retrigger the workflow

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@huggingface huggingface deleted a comment from github-actions bot May 12, 2022
@LysandreJik LysandreJik added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label May 12, 2022
@Narsil Narsil force-pushed the test-tokenizers-main branch 2 times, most recently from cebf627 to c4fd8c6 Compare August 31, 2022 17:55
@Narsil Narsil force-pushed the test-tokenizers-main branch 2 times, most recently from 1925a01 to bedb295 Compare September 13, 2022 10:18
@Narsil Narsil force-pushed the test-tokenizers-main branch 2 times, most recently from 5eb7e3e to 72b49c6 Compare September 26, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants