Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🫷 Include stop token in policy model's generation_config #2528

Merged
merged 11 commits into from
Jan 22, 2025

Conversation

dawidm
Copy link
Contributor

@dawidm dawidm commented Dec 28, 2024

Another approach to fix #2387

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Superskyyy
Copy link

Can we get this merged? Ignoring eos is painful in training setups.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec changed the title Include stop token in policy model's generation_config 🫷 Include stop token in policy model's generation_config Jan 22, 2025
@qgallouedec qgallouedec merged commit a9b54a8 into huggingface:main Jan 22, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos_token config in PPOTrainer
4 participants