Switch to using PHP namespaces #401
Conversation
To keep inline with the HM coding standards and consistency with other Human Made code, I'd like to swich S3 Uploads to namespaces, and fix up any outstanding PHP formatting issues with the HM PHPCS.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
Rather than needing to install PHP, all modules, imagemagick, and S3 APis locally, docker would be much metter suited to running out tests. This way we can run an S3 replacement (minio) instead of requiring a live integration with S3. This is better for performance and isolation of tests. It also means we have a clearly defined, consistent envirinment for tests for PHP configuration.
|
#WildIdeas |
Run tests via docker image
Fix slow call to scandir() when uploading files
|
@rmccue I have create a |
|
Ping @rmccue for a review on this. |
|
Ping @rmccue |
Co-authored-by: Ryan McCue <[email protected]>
|
@rmccue ok ready for re-review |
Co-authored-by: Ryan McCue <[email protected]>
Co-authored-by: Ryan McCue <[email protected]>
|
I'm wondering - can we get a new version cut on the v2 branch right before this change was made? This pull request breaks compatability with I think tagging 539d0c1 as 2.3.0 makes sense, and then some of the more recent features can be backported to the v2 branch while |
|
@goldenapples we can back port any fixes to v2 -- however if private attachments wasn't in v2 (sorry can't remember if it was) I don't think we should back port such a large feature that would be a lot of work. |
|
@goldenapples it could be that we merged private-attachments before this PR, if that's the case, perhaps we could tag a release, though I'd rather do it as a beta/RC as I don't think we'd want to support that as "working". If your project is already using the |
|
No, private attachments wasn't in v2. I can definitely go on using the feature branch (and I've already backported a few fixes to it). Just wanted to check on any release plans and see if it made any sense to do a release containing it. As long as the |
|
Ok cool -- I'll also open a PR on Altis for the next major version to upgrade to S3 Uploads v3 too |
To keep inline with the HM coding standards and consistency with other Human Made code, I'd like to swich S3 Uploads to namespaces, and fix up any outstanding PHP formatting issues with the HM PHPCS.