-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with get attachment image src #447
Merged
stuartshields
merged 15 commits into
private-attachments
from
fix-issue-with-get-attachment-image-src
Sep 25, 2020
Merged
Fix issue with get attachment image src #447
stuartshields
merged 15 commits into
private-attachments
from
fix-issue-with-get-attachment-image-src
Sep 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https instead of http in the plugin URI field
Add support for Private Attachments
Co-authored-by: Robert O'Rourke <[email protected]>
Update installation instructions
Build manual-install on release
Don't add resource hints if no external S3 URL is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting failed (1014 errors).
(1012 notices occurred in your codebase, but were on files/lines not included in this PR.)
Kenshino
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So while
wp_get_attachment_image_src
acceptsint
forpost_id
in some cases when doing something like the following:This will fatal. This happens because
get_post_thumbnail_id
can returnint|false
.Let's not be so strict.