Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen type signature add_s3_signed_params_to_attachment_image_src #474

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Loosen type signature add_s3_signed_params_to_attachment_image_src #474

merged 1 commit into from
Dec 11, 2020

Conversation

joehoyle
Copy link
Member

@joehoyle joehoyle commented Dec 8, 2020

Fixes #416

hm-linter[bot]
hm-linter bot reviewed Dec 8, 2020
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (3 errors).

3 notices occurred in your codebase, but none on files/lines included in this PR.

@joehoyle joehoyle mentioned this pull request Dec 8, 2020
Closed
stuartshields
stuartshields approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@stuartshields stuartshields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joehoyle Change looks good to me. Approved.

@joehoyle joehoyle merged commit 22be5ca into master Dec 11, 2020
@joehoyle joehoyle deleted the remove-typehint-int branch December 11, 2020 13:09
@joehoyle joehoyle mentioned this pull request Dec 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] left review comments

@stuartshields stuartshields stuartshields approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we remove type hinting on wp_get_attachment_image_src because of WordPress?
2 participants
@joehoyle @stuartshields