Backport #493 to v2 #497
Merged
Backport #493 to v2 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the "filesize" property in the attachment metadata when initially uploading images, so that it doesn't have to be queried for in wp_prepare_attachment_for_js() ajax response.
The attachment metadata array doesn't always have a "file" attribute. This uses the core API for getting the attached file rather than building it from the file path and the upload dir.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
joehoyle
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
@goldenapples I might be wrong, but I think we might not have used return type declarations as it's not supported by the version of PHP supported in 2x. Before merging could you just verify if we are using them elsewhere?
v2 of S3-Uploads should continue supporting older versions of PHP. Removing the return type declaration here to avoid fatals.
|
awesome thanks |
|
tagged version 2.2.3 https://github.com/humanmade/S3-Uploads/releases/tag/2.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually backports the patch from #493 to the v2 branch.
See #492.