Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload-directory command #521

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix upload-directory command #521

merged 1 commit into from
Jun 2, 2021

Conversation

iamlili
Copy link
Contributor

@iamlili iamlili commented Jun 1, 2021

@iamlili
Fix upload-directory command
a6e0ec6 
- was using incorrect namespace
@joehoyle
Copy link
Member

joehoyle commented Jun 2, 2021

Hmm wondering how this didn't get caught by the static analysis via psalm.

@joehoyle
Copy link
Member

joehoyle commented Jun 2, 2021

Ah IIRC this is to do with the WP CLI stubs not being available so the WP CLI command does not get type checking.

@joehoyle joehoyle merged commit da332fc into humanmade:master Jun 2, 2021
@joehoyle
Copy link
Member

joehoyle commented Jun 2, 2021

@iamlili thanks!

@iamlili
Copy link
Contributor Author

iamlili commented Jun 2, 2021

@joehoyle no probs!

@hm-backport hm-backport bot mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter[bot] approved these changes

@joehoyle joehoyle joehoyle approved these changes

Assignees
No one assigned
Labels
backport v3-branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must be an instance of S3_Uploads\AWS\Command, instance of Aws\Command given
3 participants
@iamlili @joehoyle @roborourke