Fix tests

humhub · Nov 14, 2024 · 65b7a5e · 65b7a5e
1 parent 49cd5b7
commit 65b7a5e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 35 deletions.
diff --git a/interfaces/CustomPagesService.php b/interfaces/CustomPagesService.php
@@ -20,6 +20,8 @@ class CustomPagesService extends Component
 
     public const EVENT_FETCH_TARGETS = 'fetchTargets';
 
+    private array $cache = [];
+
     /**
      * Fetches all available navigations for a given container.
      *
@@ -29,28 +31,18 @@ class CustomPagesService extends Component
      */
     public function getTargets(string $type, ?ContentContainerActiveRecord $container = null): array
     {
-        static $cache;
-
         $containerKey = $container ? $container->contentcontainer_id : 'global';
 
-        if (!isset($cache[$type][$containerKey])) {
+        if (!isset($this->cache[$type][$containerKey])) {
             $event = new CustomPagesTargetEvent(['type' => $type, 'container' => $container]);
             $event->addDefaultTargets();
 
             $this->trigger(self::EVENT_FETCH_TARGETS, $event);
 
-            if (!is_array($cache)) {
-                $cache = [];
-            }
-
-            if (!isset($cache[$type])) {
-                $cache[$type] = [];
-            }
-
-            $cache[$type][$containerKey] = $event->getTargets();
+            $this->cache[$type][$containerKey] = $event->getTargets();
         }
 
-        return $cache[$type][$containerKey];
+        return $this->cache[$type][$containerKey];
     }
 
     /**

diff --git a/tests/codeception/functional/InterfaceCest.php b/tests/codeception/functional/InterfaceCest.php
@@ -24,26 +24,21 @@ public function testTarget(FunctionalTester $I)
     {
         $I->wantTo('make sure users without create permission can\'t create pages');
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-
-            /* @var $event CustomPagesTargetEvent */
-
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if (!$event->container && $event->type === PageType::Page) {
                 $event->addTarget(new Target([
                     'id' => 'test',
                     'name' => 'Test Target',
                     'icon' => 'fa-bath',
                 ]));
             }
-
         });
 
         $I->amAdmin();
 
         $I->amOnRoute('/custom_pages/page');
         $I->see('Test Target', '.target-page-list');
 
-
         $I->enableModule(1, 'custom_pages');
         $I->amOnSpace1('/custom_pages/page');
         $I->see('Space Navigation');

diff --git a/tests/codeception/unit/InterfaceTest.php b/tests/codeception/unit/InterfaceTest.php
@@ -21,14 +21,16 @@ class InterfaceTest extends HumHubDbTestCase
      */
     public $service;
 
+    /**
+     * @inheritdoc
+     */
     public function _before()
     {
         parent::_before();
 
-        $this->service = new CustomPagesService();
+        $this->service = CustomPagesService::instance(true);
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-            /* @var $event CustomPagesTargetEvent */
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if ($event->container && $event->type === PageType::Page) {
                 $event->addTarget(new Target([
                     'id' => 'container',
@@ -37,30 +39,27 @@ public function _before()
             }
         });
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-            /* @var $event CustomPagesTargetEvent */
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if ($event->container && $event->type === PageType::Snippet) {
                 $event->addTarget(new Target([
                     'id' => 'containerSnippet',
                     'name' => 'Test Container Target',
-                    'type' => PageType::Snippet,
+                    'type' => $event->type,
                 ]));
             }
         });
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-            /* @var $event CustomPagesTargetEvent */
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if (!$event->container && $event->type === PageType::Snippet) {
                 $event->addTarget(new Target([
                     'id' => 'snippet',
                     'name' => 'Test Container Target',
-                    'type' => PageType::Snippet,
+                    'type' => $event->type,
                 ]));
             }
         });
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-            /* @var $event CustomPagesTargetEvent */
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if (!$event->container && $event->type === PageType::Page) {
                 $event->addTarget(new Target([
                     'id' => 'global',
@@ -70,8 +69,7 @@ public function _before()
             }
         });
 
-        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function ($event) {
-            /* @var $event CustomPagesTargetEvent */
+        Event::on(CustomPagesService::class, CustomPagesService::EVENT_FETCH_TARGETS, function (CustomPagesTargetEvent $event) {
             if (!$event->container && $event->type === PageType::Page) {
                 $event->addTarget(new Target([
                     'id' => 'global2',
@@ -218,9 +216,6 @@ public function testContentTypeValidation()
     public function testAllowedContentType()
     {
         $target = $this->service->getTargetById('global', PageType::Page);
-
-        $this->assertEquals(['debug'], $this->service->getTargets(PageType::Page));
-
         $this->assertFalse($target->isAllowedContentType(TemplateType::ID));
         $this->assertTrue($target->isAllowedContentType(MarkdownType::ID));
     }