-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Bearer Auth #112
Refactor Bearer Auth #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gevorgmansuryan Thanks, looks very good!
The current admin config is already very overloaded as we have a many options here. What do you think about splitting/rebuilding it a bit
E.g.
-
Tabs for the different features
- General (Enabled Users)
- Authentication
- Modules
-
Maybe we can leave out the checkbox for "Bearer Auth". If no tokens have been created, it is not active.
-
Maybe don't auto generate JWT Key. And leave empty for disable JWT Auth.
Other points:
- Adjust documentation for new auths
- Tests for different auths
@luke- Okay Will be done. What if we make jwt auth configurable and add enableJwtAuth checkbox like others? |
@gevorgmansuryan Thanks, looks really nice. Tests & Swagger Docs would also be good, especially for the tokens. |
@luke- |
This means that with Basic Auth all users are currently always enabled? I think it would be good to change this, and with authentication by Username & Password (Basic Auth & JWT), always allow the activated users or if checked all users.
|
Yes, it's always worked in this way Okay Will add user check for Basic Auth too, + hint |
Yes. It will work when bearer auth is enabled. |
@gevorgmansuryan Can you please check the tests? Currently only this test should fail: #114 @gevorgmansuryan Looks very good. Thank you! |
No description provided.