Enh/allow impersonate #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-
requested changes
Apr 17, 2023
There was a problem hiding this comment.
@gevorgmansuryan Does the PR include other commits? Can you please check again? Would be great to have only the Impersonate Commits to review. Got it, I'll merge the BearerAuth PR first.
Closed
|
@gevorgmansuryan Can you please try to |
done |
luke-
requested changes
Apr 17, 2023
There was a problem hiding this comment.
@gevorgmansuryan Thanks looks good. Two points:
- Can you please enhance the tests a bit
- Are expired tokens somewhere deleted? Maybe this could be done when inserting a new token..
tests/codeception/api/AuthCest.php
Outdated
| @@ -88,4 +88,17 @@ public function testCurrent(ApiTester $I) | |||
| $I->seeUserDefinition('Admin'); | |||
| } | |||
|
|
|||
| public function testImpersonate(ApiTester $I) | |||
| { | |||
| $I->wantTo('Check Impersonate'); | |||
There was a problem hiding this comment.
Can you please add a test to validate a "regular" user cannot impersonate
luke-
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#103