Skip to content

Commit

Permalink
Modals Unification Tasks - P1 Buttons
Browse files Browse the repository at this point in the history
This is a part of a larger task aimed at unifying Modals. The first step, which involves unifying button positions, has been completed to enhance the user experience.

[Project Issue 1](https://github.com/orgs/humhub/projects/31/views/1?pane=issue&itemId=88871828)
[Project Issue 2](https://github.com/orgs/humhub/projects/31/views/1?pane=issue&itemId=88873119)

Issue tracker
humhub/office_tasks#328

Project
https://github.com/orgs/humhub/projects/31
  • Loading branch information
mbumpalumpa committed Nov 27, 2024
1 parent 3bbd4f6 commit 04d7d0c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion views/list/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
</div>
</div>
<div class="modal-footer">
<?= ModalButton::submitModal() ?>
<?= ModalButton::cancel() ?>
<?= ModalButton::submitModal() ?>
</div>
<?php ActiveForm::end() ?>
<?php ModalDialog::end() ?>
2 changes: 1 addition & 1 deletion views/task/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@

<div class="modal-footer">
<div class="col-md-12 text-center">
<?= ModalButton::submitModal($taskForm->getSubmitUrl()); ?>
<?= ModalButton::cancel(); ?>
<?= ModalButton::submitModal($taskForm->getSubmitUrl()); ?>
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion views/task/modal.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
<?= $this->renderAjax('modal_entry', ['task' => $task])?>
</div>
<div class="modal-footer">
<?= ModalButton::cancel(Yii::t('TasksModule.base', 'Close')) ?>
<?php if($canManageEntries): ?>
<?= ModalButton::primary(Yii::t('TasksModule.base', 'Edit'))->load($editUrl)->loader(true); ?>
<?php endif; ?>
<?= ModalButton::cancel(Yii::t('TasksModule.base', 'Close')) ?>
</div>
<?php ModalDialog::end(); ?>

0 comments on commit 04d7d0c

Please sign in to comment.