Merge pull request #250 from humhub/enh/229-disable-main-navigation-b…

…y-default Disable main navigation by default
humhub · Feb 1, 2024 · d458628 · d458628
2 parents f94545b + e815d04
commit d458628
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/Events.php b/Events.php
@@ -45,7 +45,7 @@ public static function onTopMenuInit($event)
             $module = Yii::$app->getModule('tasks');
 
 
-            if (!(int)$module->settings->get('showGlobalMenuItem', 1) || Yii::$app->user->isGuest) {
+            if (!$module->settings->get('showGlobalMenuItem', false) || Yii::$app->user->isGuest) {
                 return;
             }
 

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -4,6 +4,7 @@ Changelog
 1.8.5 (Unreleased)
 -------------------------
 - Fix #249: Fix replaced method `friendship\Module::isEnabled()`
+- Enh #229: Disable main navigation by default
 
 1.8.4 (December 21, 2023)
 -------------------------

diff --git a/models/SnippetModuleSettings.php b/models/SnippetModuleSettings.php
@@ -39,7 +39,7 @@ class SnippetModuleSettings extends Model
     /**
      * @var int defines if the global task menu item should be displayed
      */
-    public $showGlobalMenuItem = 1;
+    public $showGlobalMenuItem = false;
     public $menuSortOrder = 500;
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,7 @@ public static function onTopMenuInit($event) @@
                 $module = Yii::$app->getModule('tasks');
-                if (!(int)$module->settings->get('showGlobalMenuItem', 1) || Yii::$app->user->isGuest) {
+                if (!$module->settings->get('showGlobalMenuItem', false) || Yii::$app->user->isGuest) {
                     return;
                 }
@@ Expand Down @@