Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15] Update tests to v1.15 #237

Merged
merged 4 commits into from
Dec 7, 2023
Merged

[1.15] Update tests to v1.15 #237

merged 4 commits into from
Dec 7, 2023

Conversation

yurabakhtin
Copy link
Contributor

Issue: https://github.com/humhub/humhub-internal/issues/191

Need this fix because some methods were modified to static here humhub/humhub@4a29d7a for v1.15.

@yurabakhtin yurabakhtin requested a review from luke- September 4, 2023 20:02
Copy link
Contributor

@luke- luke- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurabakhtin Can we restore the master test file?

@yurabakhtin
Copy link
Contributor Author

@yurabakhtin Can we restore the master test file?

@luke- Yes, we can, but I am not sure we should do this because it was not done by me here humhub/humhub#6480.
As I understand PHP allows to call static methods as $this->method(), so we should not touch modules where only the method calls are used, but this module "Tasks" redefines the parent method assertHasNoNotification, and I have compared the tasks child method with core parent method and find only one difference:

  • core: 'source_class' => PolymorphicRelation::getObjectModel($source),
  • module: 'source_class' => $source->className(),

I think results are same, so I have just removed the methods from tasks module side, also I have reverted min version to 1.14, please merge this PR because it works well on previous min version and on all others as you can see all commits have all tests as green.

@luke-
Copy link
Contributor

luke- commented Dec 7, 2023

@yurabakhtin Thanks, the solution looks good to me.

@luke- luke- merged commit 1dbc55d into master Dec 7, 2023
14 checks passed
@luke- luke- deleted the fix/test-v1.15 branch December 7, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants