Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of the method Controller::getAccessRules() #242

Merged
merged 1 commit into from
Oct 25, 2023
+24 −9
Merged

Fix visibility of the method Controller::getAccessRules() #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions controllers/ChecklistController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@

class ChecklistController extends AbstractTaskController
{
public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
[ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]]
Expand All @@ -36,4 +39,4 @@ public function actionCheckItem($id, $taskId)

return $this->asJson(['success' => false, 'message' => ($model->hasErrors()) ? $model->getFirstErrors() : '']);
}
}
}
2 changes: 1 addition & 1 deletion controllers/ConfigController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ConfigController extends Controller
/**
* @inheritdoc
*/
public function getAccessRules()
protected function getAccessRules()
{
return [['permissions' => ManageModules::class]];
}
Expand Down
7 changes: 5 additions & 2 deletions controllers/GlobalController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ class GlobalController extends AbstractTaskController
{
public $requireContainer = false;

public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
[ControllerAccess::RULE_LOGGED_IN_ONLY]
Expand All @@ -44,4 +47,4 @@ public function actionFilter()
]);
}

}
}
5 changes: 4 additions & 1 deletion controllers/ListController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@

class ListController extends AbstractTaskController
{
public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
[ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]],
Expand Down
6 changes: 4 additions & 2 deletions controllers/SearchController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
class SearchController extends AbstractTaskController
{

public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
[ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]]
Expand Down Expand Up @@ -67,4 +70,3 @@ public function actionJson()
}

}

5 changes: 4 additions & 1 deletion controllers/TaskController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ class TaskController extends AbstractTaskController

public $hideSidebar = true;

public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
[ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]],
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Changelog
- Fix #234: Fix using of Yii on view files
- Fix #236: Fix pagination design
- Enh #238: Tests for `next` version
- Fix #242: Fix visibility of the method `Controller::getAccessRules()`

1.8.1 (May 1, 2023)
-------------------
Expand Down
Loading