Fix seal_status Call #354
Merged
Fix seal_status Call #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2018 11:28
jeffwecan
added
bug
system backend
Codecov Report
@@ Coverage Diff @@
## develop #354 +/- ##
==========================================
+ Coverage 91.29% 91.39% +0.1%
==========================================
Files 42 42
Lines 2216 2232 +16
==========================================
+ Hits 2023 2040 +17
+ Misses 193 192 -1
|
jeffwecan
added a commit
to jeffwecan/hvac
that referenced
this pull request
Dec 19, 2018
* Add regression tests * Fix seal_status call * More meaningful assertion
Merged
jeffwecan
added a commit
that referenced
this pull request
Dec 19, 2018
* Develop is the new integration branch * Handle "Misses" for Identity Secrets Lookups (#331) * Regression tests for group lookup misses * Return None for group lookup misses * Regression tests for entity lookup misses * Return None for entity lookup misses * Also update docstrings * Move Test Cases out of Package Directory (#334) * use utils function to get test data path * rename test => tests and move contents into config_files subdir * Move scripts subdir under tests dir in root * Move generate.sh into scripts subdir * Update paths in generate_test_cert.sh * clean up config_files readme a smidge * move test dir into repo root dir * update import paths * start breaking out test utils into module * Break out mock_github_request_handler * Break out hvac_integration_test_case * Break out server_manager * Remove .coveragerc until / unless it is needed once again * Add Okta Auth Method Class (#341) * Rename auth subdir under unit_tests * bonus GCP docs heading fix * Add Okta auth method docs * Add Okta auth method test cases * Add Okta auth method class implementation * Add pretty_print arg to create_or_update_policy (#342) * Add pretty_print arg * Skip new test on Vault v0.11.0 * Bump Vault Versions - Vault v1.0.0 (#344) * fix TOXENV for 3.6 jobs * Drop v0.8.3, add v1.0.0 * Update readme * Handle different response keys in Vault v1.0.0 * Also work around new list response return type * Add get_generate_root_otp utils method for v1.0.0 and/or previous vers * Update missed TOXENV arg under allow_failures dict * Call out why v0.11.0 is hanging about * Clarify name/purpose of vault ver comparison methods * Fix identity group conditionals (#346) * Add regression tests * Fix member entity/group ids logic in group methods * DRY up conditional logic * Add missing docstring content * Gcp login doc update for issue 345 (#350) * Clarify source links * add google-api-python-client example * Clean up unintentional modification * Fix For read_health_status() Exception Handling (#347) * Add url param for create_client * Install consul for test cases involving Vault HA * Update test harness with optional Vault HA / consul set up * Add regerssion test cases for issue #339 * Add raise_exception param to requests * Use raise_exception param in read_health_status method * Add ipaddress module per github.com/urllib3/urllib3/issues/1117? Somehow ended up with this urllib3 error for python 2.7 otherwise: "urllib3.connection: ERROR: Certificate did not match expected hostname: 127.0.0.1. Certificate: {'serialNumber': u'8D267F50728FF454', 'subject': ((('commonName', u'localhost'),),), 'notAfter': 'May 14 22:44:13 2025 GMT', 'notBefore': u'May 17 22:44:13 2015 GMT', 'subjectAltName': (('DNS', 'localhost'), ('IP Address', '127.0.0.1')), 'issuer': ((('commonName', u'localhost'),),), 'version': 3L} * Clarify docstring a bit * Also add cases to cover both HEAD and GET methods * Remove standby node magic strings; use method instead * Fix seal_status Call (#354) * Add regression tests * Fix seal_status call * More meaningful assertion * Fix Request Redirection Handling (#348) * simplify chained comparison * Ensure regression unit test case coverage for paths/redirects * Revert redirection handling back to the requests module * Handle double slashes in paths * Fix syntax for python 2.7 * Log when we transform a requested url * Explictly assert that we have the expect requests in mocker history * Clarify lease docs (#355) * Updates for upcoming release 0.7.1 * Bump patch version to 0.7.1 * prune tests from packages (#356)
jeffwecan
added a commit
that referenced
this pull request
Dec 25, 2018
* fix double slash (#352) When called, double slash results in 301 HTTP code and the redirect which is necessary * Release v0.7.1 (#357) * Develop is the new integration branch * Handle "Misses" for Identity Secrets Lookups (#331) * Regression tests for group lookup misses * Return None for group lookup misses * Regression tests for entity lookup misses * Return None for entity lookup misses * Also update docstrings * Move Test Cases out of Package Directory (#334) * use utils function to get test data path * rename test => tests and move contents into config_files subdir * Move scripts subdir under tests dir in root * Move generate.sh into scripts subdir * Update paths in generate_test_cert.sh * clean up config_files readme a smidge * move test dir into repo root dir * update import paths * start breaking out test utils into module * Break out mock_github_request_handler * Break out hvac_integration_test_case * Break out server_manager * Remove .coveragerc until / unless it is needed once again * Add Okta Auth Method Class (#341) * Rename auth subdir under unit_tests * bonus GCP docs heading fix * Add Okta auth method docs * Add Okta auth method test cases * Add Okta auth method class implementation * Add pretty_print arg to create_or_update_policy (#342) * Add pretty_print arg * Skip new test on Vault v0.11.0 * Bump Vault Versions - Vault v1.0.0 (#344) * fix TOXENV for 3.6 jobs * Drop v0.8.3, add v1.0.0 * Update readme * Handle different response keys in Vault v1.0.0 * Also work around new list response return type * Add get_generate_root_otp utils method for v1.0.0 and/or previous vers * Update missed TOXENV arg under allow_failures dict * Call out why v0.11.0 is hanging about * Clarify name/purpose of vault ver comparison methods * Fix identity group conditionals (#346) * Add regression tests * Fix member entity/group ids logic in group methods * DRY up conditional logic * Add missing docstring content * Gcp login doc update for issue 345 (#350) * Clarify source links * add google-api-python-client example * Clean up unintentional modification * Fix For read_health_status() Exception Handling (#347) * Add url param for create_client * Install consul for test cases involving Vault HA * Update test harness with optional Vault HA / consul set up * Add regerssion test cases for issue #339 * Add raise_exception param to requests * Use raise_exception param in read_health_status method * Add ipaddress module per github.com/urllib3/urllib3/issues/1117? Somehow ended up with this urllib3 error for python 2.7 otherwise: "urllib3.connection: ERROR: Certificate did not match expected hostname: 127.0.0.1. Certificate: {'serialNumber': u'8D267F50728FF454', 'subject': ((('commonName', u'localhost'),),), 'notAfter': 'May 14 22:44:13 2025 GMT', 'notBefore': u'May 17 22:44:13 2015 GMT', 'subjectAltName': (('DNS', 'localhost'), ('IP Address', '127.0.0.1')), 'issuer': ((('commonName', u'localhost'),),), 'version': 3L} * Clarify docstring a bit * Also add cases to cover both HEAD and GET methods * Remove standby node magic strings; use method instead * Fix seal_status Call (#354) * Add regression tests * Fix seal_status call * More meaningful assertion * Fix Request Redirection Handling (#348) * simplify chained comparison * Ensure regression unit test case coverage for paths/redirects * Revert redirection handling back to the requests module * Handle double slashes in paths * Fix syntax for python 2.7 * Log when we transform a requested url * Explictly assert that we have the expect requests in mocker history * Clarify lease docs (#355) * Updates for upcoming release 0.7.1 * Bump patch version to 0.7.1 * prune tests from packages (#356)
jeffwecan
added a commit
that referenced
this pull request
Jan 1, 2019
* Tweak Travis CI Configuration (#360) * drop sudo: false * remove explicit dist * simplify build matrix * change flake8 toxenv name to avoid matching tox-travis default prefixes * Remove unnecessary `export PATH` "script" step * Simplify env from list to k/v string * Clarifying comment re: flake8 * Simplify "allowed failures" row matching * Speed up overall build time with fast_finish: true * Rearrange comment to same line being commented on * Include python 3.7 build jobs * Bump 0.11 and 1.0 Vault vers to latest patch ver * Also run flake8 for python 3.7 * Also include "py37" on the tox side of things * Keep "dist: xenial" for python 3.7 availability * Tweak flake8 job names for readability * Shorten comment * Backporting Master (#362) * fix double slash (#352) When called, double slash results in 301 HTTP code and the redirect which is necessary * Release v0.7.1 (#357) * Develop is the new integration branch * Handle "Misses" for Identity Secrets Lookups (#331) * Regression tests for group lookup misses * Return None for group lookup misses * Regression tests for entity lookup misses * Return None for entity lookup misses * Also update docstrings * Move Test Cases out of Package Directory (#334) * use utils function to get test data path * rename test => tests and move contents into config_files subdir * Move scripts subdir under tests dir in root * Move generate.sh into scripts subdir * Update paths in generate_test_cert.sh * clean up config_files readme a smidge * move test dir into repo root dir * update import paths * start breaking out test utils into module * Break out mock_github_request_handler * Break out hvac_integration_test_case * Break out server_manager * Remove .coveragerc until / unless it is needed once again * Add Okta Auth Method Class (#341) * Rename auth subdir under unit_tests * bonus GCP docs heading fix * Add Okta auth method docs * Add Okta auth method test cases * Add Okta auth method class implementation * Add pretty_print arg to create_or_update_policy (#342) * Add pretty_print arg * Skip new test on Vault v0.11.0 * Bump Vault Versions - Vault v1.0.0 (#344) * fix TOXENV for 3.6 jobs * Drop v0.8.3, add v1.0.0 * Update readme * Handle different response keys in Vault v1.0.0 * Also work around new list response return type * Add get_generate_root_otp utils method for v1.0.0 and/or previous vers * Update missed TOXENV arg under allow_failures dict * Call out why v0.11.0 is hanging about * Clarify name/purpose of vault ver comparison methods * Fix identity group conditionals (#346) * Add regression tests * Fix member entity/group ids logic in group methods * DRY up conditional logic * Add missing docstring content * Gcp login doc update for issue 345 (#350) * Clarify source links * add google-api-python-client example * Clean up unintentional modification * Fix For read_health_status() Exception Handling (#347) * Add url param for create_client * Install consul for test cases involving Vault HA * Update test harness with optional Vault HA / consul set up * Add regerssion test cases for issue #339 * Add raise_exception param to requests * Use raise_exception param in read_health_status method * Add ipaddress module per github.com/urllib3/urllib3/issues/1117? Somehow ended up with this urllib3 error for python 2.7 otherwise: "urllib3.connection: ERROR: Certificate did not match expected hostname: 127.0.0.1. Certificate: {'serialNumber': u'8D267F50728FF454', 'subject': ((('commonName', u'localhost'),),), 'notAfter': 'May 14 22:44:13 2025 GMT', 'notBefore': u'May 17 22:44:13 2015 GMT', 'subjectAltName': (('DNS', 'localhost'), ('IP Address', '127.0.0.1')), 'issuer': ((('commonName', u'localhost'),),), 'version': 3L} * Clarify docstring a bit * Also add cases to cover both HEAD and GET methods * Remove standby node magic strings; use method instead * Fix seal_status Call (#354) * Add regression tests * Fix seal_status call * More meaningful assertion * Fix Request Redirection Handling (#348) * simplify chained comparison * Ensure regression unit test case coverage for paths/redirects * Revert redirection handling back to the requests module * Handle double slashes in paths * Fix syntax for python 2.7 * Log when we transform a requested url * Explictly assert that we have the expect requests in mocker history * Clarify lease docs (#355) * Updates for upcoming release 0.7.1 * Bump patch version to 0.7.1 * prune tests from packages (#356) * Wait for test kvv2 secrets engine to show up in list (#361) * Set "skip_missing_interpreters" to true in global tox config (#363) * Set "skip_missing_interpreters" to true in global tox config * go full env string expansion 😝 cause why not * Fix For Intermittent Health Test Case Failure (#364) * Ensure we get an active node when needed * Remove unneeded debug call * Simplify flake8 env for travis-ci + tox (#365) * Simplify flake8 env for travis-ci + tox * Add missing comma * Test Documentation Compilation (#366) * Update docs requirements to be more explicit * Test that docs can build cleanly * Fix m2r requirement * Clearer job name * Default to first python ver in the matrix... * Further clarify job name * Reorder tox directives a smidge... * Cleanup setup.py a bit (#367) * Update author / author_email * Move some auxiliary logic into methods * gmai.com -> gmail.com * reorder author names * Use pip-compile For All Requirements (#368) * Add section covering requirement updates * Add .in req files, breakout parser (pyhcl) extra_require * pip-compile all the things * Pull in latest reqs for docs for good measure * Add update-all-reqs Makefile targets * Define "parser" requirements in just one place * Add clarifying comment * Simplify new Makefile targets a smidge * comment bout comments * Makefile clarifying comment * Use abs paths starting from setup.py location * Also dynamically populate install_requires * Revert requirements loading in setup.py; tis a silly thing to do * Bump install_requires / extras_require min versions * Drop extra "parser" requirements as its not strictly needed * Drop use of "version" file (#369) * Drop use of "version" file * Clarify updated bumpversion release step * Fix grammerz * Remove inadvertently committed hvac/version file * Organize imports * Add AWS Secrets Engine Class (#370) * auto generated script * Include Docs * "Implement" Aws class * Tweak docstrings and whatnot * Param tweaks * update convert ttl for aws secrets return values * First pass on aws secrets engine tests * Fix headings * Cleanup unused mock server logic, additional role params * Accept policy_document dict param type * Start filling in aws secrets docs * E501 line too long (162 > 160 characters) * First pass at handling legacy params * Different status code from Vault v0.11.0 :\ * Fill in legacy_params-related comments / docstrings * Also update docs * Add contents section and upper case heading * Adding a Twitter Badge (#372) * Split up icons with linebreaks * Add Twitter badge for @hvac_python * Adding Header image (#373) * Add header image * Update twitter handle * Update content email and test URLs * Commit header image * Update header image URL to final resting place * Changelog updates for v0.7.2 release * Update release steps * Update copyright date * Bump version: 0.7.1 → 0.7.2 * Clean up vestigial version target reference
Closed
jeffwecan
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Release v0.7.2 (#371) * Tweak Travis CI Configuration (#360) * drop sudo: false * remove explicit dist * simplify build matrix * change flake8 toxenv name to avoid matching tox-travis default prefixes * Remove unnecessary `export PATH` "script" step * Simplify env from list to k/v string * Clarifying comment re: flake8 * Simplify "allowed failures" row matching * Speed up overall build time with fast_finish: true * Rearrange comment to same line being commented on * Include python 3.7 build jobs * Bump 0.11 and 1.0 Vault vers to latest patch ver * Also run flake8 for python 3.7 * Also include "py37" on the tox side of things * Keep "dist: xenial" for python 3.7 availability * Tweak flake8 job names for readability * Shorten comment * Backporting Master (#362) * fix double slash (#352) When called, double slash results in 301 HTTP code and the redirect which is necessary * Release v0.7.1 (#357) * Develop is the new integration branch * Handle "Misses" for Identity Secrets Lookups (#331) * Regression tests for group lookup misses * Return None for group lookup misses * Regression tests for entity lookup misses * Return None for entity lookup misses * Also update docstrings * Move Test Cases out of Package Directory (#334) * use utils function to get test data path * rename test => tests and move contents into config_files subdir * Move scripts subdir under tests dir in root * Move generate.sh into scripts subdir * Update paths in generate_test_cert.sh * clean up config_files readme a smidge * move test dir into repo root dir * update import paths * start breaking out test utils into module * Break out mock_github_request_handler * Break out hvac_integration_test_case * Break out server_manager * Remove .coveragerc until / unless it is needed once again * Add Okta Auth Method Class (#341) * Rename auth subdir under unit_tests * bonus GCP docs heading fix * Add Okta auth method docs * Add Okta auth method test cases * Add Okta auth method class implementation * Add pretty_print arg to create_or_update_policy (#342) * Add pretty_print arg * Skip new test on Vault v0.11.0 * Bump Vault Versions - Vault v1.0.0 (#344) * fix TOXENV for 3.6 jobs * Drop v0.8.3, add v1.0.0 * Update readme * Handle different response keys in Vault v1.0.0 * Also work around new list response return type * Add get_generate_root_otp utils method for v1.0.0 and/or previous vers * Update missed TOXENV arg under allow_failures dict * Call out why v0.11.0 is hanging about * Clarify name/purpose of vault ver comparison methods * Fix identity group conditionals (#346) * Add regression tests * Fix member entity/group ids logic in group methods * DRY up conditional logic * Add missing docstring content * Gcp login doc update for issue 345 (#350) * Clarify source links * add google-api-python-client example * Clean up unintentional modification * Fix For read_health_status() Exception Handling (#347) * Add url param for create_client * Install consul for test cases involving Vault HA * Update test harness with optional Vault HA / consul set up * Add regerssion test cases for issue #339 * Add raise_exception param to requests * Use raise_exception param in read_health_status method * Add ipaddress module per github.com/urllib3/urllib3/issues/1117? Somehow ended up with this urllib3 error for python 2.7 otherwise: "urllib3.connection: ERROR: Certificate did not match expected hostname: 127.0.0.1. Certificate: {'serialNumber': u'8D267F50728FF454', 'subject': ((('commonName', u'localhost'),),), 'notAfter': 'May 14 22:44:13 2025 GMT', 'notBefore': u'May 17 22:44:13 2015 GMT', 'subjectAltName': (('DNS', 'localhost'), ('IP Address', '127.0.0.1')), 'issuer': ((('commonName', u'localhost'),),), 'version': 3L} * Clarify docstring a bit * Also add cases to cover both HEAD and GET methods * Remove standby node magic strings; use method instead * Fix seal_status Call (#354) * Add regression tests * Fix seal_status call * More meaningful assertion * Fix Request Redirection Handling (#348) * simplify chained comparison * Ensure regression unit test case coverage for paths/redirects * Revert redirection handling back to the requests module * Handle double slashes in paths * Fix syntax for python 2.7 * Log when we transform a requested url * Explictly assert that we have the expect requests in mocker history * Clarify lease docs (#355) * Updates for upcoming release 0.7.1 * Bump patch version to 0.7.1 * prune tests from packages (#356) * Wait for test kvv2 secrets engine to show up in list (#361) * Set "skip_missing_interpreters" to true in global tox config (#363) * Set "skip_missing_interpreters" to true in global tox config * go full env string expansion 😝 cause why not * Fix For Intermittent Health Test Case Failure (#364) * Ensure we get an active node when needed * Remove unneeded debug call * Simplify flake8 env for travis-ci + tox (#365) * Simplify flake8 env for travis-ci + tox * Add missing comma * Test Documentation Compilation (#366) * Update docs requirements to be more explicit * Test that docs can build cleanly * Fix m2r requirement * Clearer job name * Default to first python ver in the matrix... * Further clarify job name * Reorder tox directives a smidge... * Cleanup setup.py a bit (#367) * Update author / author_email * Move some auxiliary logic into methods * gmai.com -> gmail.com * reorder author names * Use pip-compile For All Requirements (#368) * Add section covering requirement updates * Add .in req files, breakout parser (pyhcl) extra_require * pip-compile all the things * Pull in latest reqs for docs for good measure * Add update-all-reqs Makefile targets * Define "parser" requirements in just one place * Add clarifying comment * Simplify new Makefile targets a smidge * comment bout comments * Makefile clarifying comment * Use abs paths starting from setup.py location * Also dynamically populate install_requires * Revert requirements loading in setup.py; tis a silly thing to do * Bump install_requires / extras_require min versions * Drop extra "parser" requirements as its not strictly needed * Drop use of "version" file (#369) * Drop use of "version" file * Clarify updated bumpversion release step * Fix grammerz * Remove inadvertently committed hvac/version file * Organize imports * Add AWS Secrets Engine Class (#370) * auto generated script * Include Docs * "Implement" Aws class * Tweak docstrings and whatnot * Param tweaks * update convert ttl for aws secrets return values * First pass on aws secrets engine tests * Fix headings * Cleanup unused mock server logic, additional role params * Accept policy_document dict param type * Start filling in aws secrets docs * E501 line too long (162 > 160 characters) * First pass at handling legacy params * Different status code from Vault v0.11.0 :\ * Fill in legacy_params-related comments / docstrings * Also update docs * Add contents section and upper case heading * Adding a Twitter Badge (#372) * Split up icons with linebreaks * Add Twitter badge for @hvac_python * Adding Header image (#373) * Add header image * Update twitter handle * Update content email and test URLs * Commit header image * Update header image URL to final resting place * Changelog updates for v0.7.2 release * Update release steps * Update copyright date * Bump version: 0.7.1 → 0.7.2 * Clean up vestigial version target reference * add auth method for Kubernetes * add tests for Kubernetes auth method * add function for check certificate PEM format * update project common files * change dict multiline to oneline * fix gcp integration tests with bound_service_accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #353