Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain | Rework bundle structure to match Symfony best practices #1799

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Maintain | Rework bundle structure to match Symfony best practices #1799

merged 1 commit into from
Dec 10, 2021

Conversation

stloyd
Copy link
Collaborator

@stloyd stloyd commented Sep 6, 2021 •
edited
Loading

Reworked bundles structure to match Symfony best practices:

  • bundle code moved to: src/,
  • tests moved to: tests/,
  • docs moved from Resources/doc into: docs/

Closes #1798.

@stloyd stloyd added this to the 2.0 - Game changer milestone Sep 6, 2021
@stloyd stloyd requested a review from XWB September 6, 2021 09:40
@stloyd stloyd self-assigned this Sep 6, 2021
@stloyd stloyd force-pushed the task/1798 branch 2 times, most recently from 58a458f to 19e4a78 Compare September 6, 2021 09:44
dmaicher
dmaicher reviewed Sep 6, 2021
View reviewed changes
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also move translations from /Resources/translations into /translations?

@stloyd
Copy link
Collaborator Author

stloyd commented Sep 7, 2021 •
edited
Loading

@dmaicher tried to move them as well the views directory but after that bundle stopped to work...

@XWB
Copy link
Member

XWB commented Sep 14, 2021

Looking good so far, just a few merge conflicts :)

@stloyd stloyd merged commit 3dfd2c8 into hwi:master Dec 10, 2021
@stloyd stloyd deleted the task/1798 branch December 10, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher left review comments

@XWB XWB Awaiting requested review from XWB

Assignees

@stloyd stloyd

Labels
Enhancement
Projects
None yet
Milestone
2.0 - Game changer
Development

Successfully merging this pull request may close these issues.

RFC | Adapt codebase structure to latest Symfony best practices
3 participants
@stloyd @XWB @dmaicher