-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC | Lets switch configs from xml to php #1859
Conversation
085a14d
to
344271f
Compare
I think the last commit must be reverted. phpstan moans about security_v5.php (SecurityConfig not exists), old yaml testapp configs are more cleaner. |
4aaf30a
to
022927d
Compare
Cleaned. |
Personally I would leave yaml files and recommend php ones, IMHO change is not really significant to force people to change ie routing files etc Also there is needed change in documentation to recommend php ones as there is either xml or yaml. |
As said, IMHO we should revert yaml routing removal, other are not affecting end users. After that we can reword changelog cause it will be no more BC break but deprecation. |
fb88e5f
to
6045247
Compare
I wrote whole time about |
6045247
to
13c08d3
Compare
Merged, thanks @gassan ! |
Symfony rewritten configs for all own packages to php. it is done here for hwi-oauth too.
Some links: https://tomasvotruba.com/blog/2020/07/16/10-cool-features-you-get-after-switching-from-yaml-to-php-configs/
PS: Old files not yet removed so that you can compare them before merge.