Removed option firewall_names #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassan
force-pushed
the
no-firewall-names
branch
from
c31a97c to
09a41fb
Compare
XWB
reviewed
Dec 23, 2021
| @@ -156,8 +156,8 @@ public function getConfigTreeBuilder() | |||
| ->fixXmlConfig('firewall_name') | |||
| ->children() | |||
| ->arrayNode('firewall_names') | |||
| ->isRequired() | |||
| ->requiresAtLeastOneElement() | |||
| ->setDeprecated('hwi/oauth-bundle', '2.0', '"%path%.%node%" is deprecated. Firewall names are collected automatically.') | |||
There was a problem hiding this comment.
Well, as 2.0 is not yet final we could deprecate this in 1.x (1.5?) and remove it in 2.0
There was a problem hiding this comment.
I thought this commits are for 2.0 only. Is version 1.5 also planned?
There was a problem hiding this comment.
if required I can prepare commits for 1.x-dev too.
There was a problem hiding this comment.
I don't want to have any 1.5, I can leave with this deprecation in 2.0 :)
gassan
force-pushed
the
no-firewall-names
branch
from
09a41fb to
1d647a6
Compare
stloyd
requested changes
Dec 24, 2021
|
|
gassan
force-pushed
the
no-firewall-names
branch
5 times, most recently
from
0e69571 to
7809b43
Compare
gassan
force-pushed
the
no-firewall-names
branch
from
7809b43 to
481517e
Compare
XWB
approved these changes
Dec 26, 2021
stloyd
approved these changes
Dec 27, 2021
|
Nice job @gassan 🎉 |
gassan
added a commit
to gassan/HWIOAuthBundle
that referenced
this pull request
Jan 23, 2022
…wner check path links. fixes hwi#1864
gassan
added a commit
to gassan/HWIOAuthBundle
that referenced
this pull request
Jan 23, 2022
…wner check path links. fixes hwi#1864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewall names are collected automatically.
oauthauthenticator/provider, thenfirewallNameis stored in HWIOAuthExtension property.