Add batched_sink utility for flushing sink elements together
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
force-pushed
the
pr574
branch
3 times, most recently
from
2fdb583 to
9e0143e
Compare
MingweiSamuel
approved these changes
Apr 12, 2023
| /// when the data is actually flushed. | ||
| #[hydroflow_internalmacro::operator_docgen] | ||
| pub const DEST_SINK_CHUNKED: OperatorConstraints = OperatorConstraints { | ||
| name: "dest_sink_chunked", |
There was a problem hiding this comment.
Seems like it should be dest_sink_batched?
|
Draft for now because we haven't proven that this actually helps yet. |
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
b0c3916 to
5d48544
Compare
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
e9a87eb to
6039078
Compare
MingweiSamuel
force-pushed
the
main
branch
4 times, most recently
from
4f84634 to
0e64791
Compare
MingweiSamuel
force-pushed
the
main
branch
2 times, most recently
from
fb8b3b3 to
a2ec110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
batched_sinkutility for flushing sink elements together