Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation of server code independent of tonic transport #281

Closed
mzabaluev opened this issue Mar 3, 2020 · 3 comments · Fixed by #306
Closed

Generation of server code independent of tonic transport #281

mzabaluev opened this issue Mar 3, 2020 · 3 comments · Fixed by #306
Labels
A-build C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much
Milestone
0.2

Comments

@mzabaluev
Copy link

Feature Request

Crates

tonic-build

Motivation

In version 0.1.1, disabling feature transport in both tonic and tonic-build results in generated server code that does not compile due to an unconditional dependency on tonic::codegen::HyperBody.
Such coupling is not present in the client code, where it is possible to use the generic client with other Service impls, not necessarily dependent on hyper.

Proposal

The generated Service impl should be generic over the body type, with suitable bounds that are implemented for hyper::Body.
@LucioFranco
Copy link
Member

@mzabaluev yup you are right, master just got some breaking changes, so this will be fixed in 0.2 which should be coming out soonish.

@LucioFranco LucioFranco added C-bug Category: Something isn't working A-build labels Mar 6, 2020
@LucioFranco LucioFranco added this to the 0.2 milestone Mar 27, 2020
@LucioFranco LucioFranco added the E-easy Call for participation: Experience needed to fix: Easy / not much label Mar 27, 2020
@bnjjj
Copy link
Contributor

bnjjj commented Mar 27, 2020

I'm interested for working on this issue for this weekend :) I'll send you a PR to open a discussion

@LucioFranco
Copy link
Member

Great! I have not fully scoped this issue out, but feel free to chat with us on discord about it :)

bnjjj added a commit to bnjjj/tonic that referenced this issue Mar 28, 2020
@bnjjj
fix(codegen): Generation of server code independent of tonic transport …
1f5e709 
…hyperium#281

Signed-off-by: Benjamin Coenen <[email protected]>
@bnjjj bnjjj mentioned this issue Mar 28, 2020
Merged
bnjjj added a commit to bnjjj/tonic that referenced this issue Mar 28, 2020
@bnjjj
fix(codegen): Generation of server code independent of tonic transport …
5b00a7c 
…hyperium#281

Signed-off-by: Benjamin Coenen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build C-bug Category: Something isn't working E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

fix(build): Server service uses generic body bound bnjjj/tonic
3 participants
@mzabaluev @bnjjj @LucioFranco