feat(transport): port router to axum #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Nov 8, 2021
LucioFranco
approved these changes
Nov 15, 2021
🔥 I think this is one of the most exciting PRs we've had in a while, super hyped for this!
|
We also probably want to consider doing a blog post for this, since it shows how the ecosystem can glue together and that tonic and axum are not really competitors in a sense. |
Thats a great idea! I'll do that when we ship the next major version of tonic 😊 |
Closed
LucioFranco
reviewed
Feb 18, 2022
| where | ||
| S: Service<Request<Body>, Response = Response<BoxBody>> | ||
| S: Service<Request<Body>, Response = Response<BoxBody>, Error = Infallible> |
There was a problem hiding this comment.
Should we do this in this PR or another but we should maybe makeRequest<impl Body> instead of hard coding it to hyper?
There was a problem hiding this comment.
Good idea. I think we should explore it separately though.
LucioFranco
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports tonic's previous routing setup to axum. This is mostly just a proposal. I think it lead to some decent wins but might not make that much difference in practice. Its a breaking change so we have to wait until 0.7 if we decide to go this way.
Neversince axum requires services to useInfallible. Can easily convert between them but if we're making breaking changes we might as well removeNever.add_servicenow requires service's to be infallible. This shouldn't cause any breakage since generated services were already infallible, the trait bounds just didn't require it.