Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search and indexing can run together, and do so as a default Issue/1160 #1163

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Search and indexing can run together, and do so as a default Issue/1160 #1163

merged 1 commit into from
Mar 28, 2022

Conversation

fulmicoton
Copy link
Contributor

@fulmicoton fulmicoton commented Mar 11, 2022 •
edited
Loading

This PR makes it possible to run indexing and search together.

They are now "services"...
The gRPC and the rest server are always running and make all running services available.

In order to make it possible, we will be temporarily relying on a specific unpublished rev of tonic,
to benefit from the following PR.
TLDR the generic in tonic's router have been removed very recently.
In other words, the type of a gRPC does not depend on the subset of service that are being mounted.

hyperium/tonic#830

  • This PR also makes a couple of code improvement. ClusterServiceImpl is removed as it was useless.
  • Useless generics have been removed in quickwit-serve.

Closes #1160

@fulmicoton fulmicoton force-pushed the issue/1160 branch 4 times, most recently from ab3063c to f139638 Compare March 11, 2022 09:11
@fulmicoton fulmicoton requested review from fmassot and removed request for fmassot March 11, 2022 09:56
@fulmicoton fulmicoton marked this pull request as draft March 11, 2022 09:56
@fulmicoton fulmicoton requested a review from fmassot March 11, 2022 09:56
@fulmicoton fulmicoton changed the title Issue/1160 Search and indexing can run together, and do so as a default Issue/1160 Mar 11, 2022
@fulmicoton fulmicoton marked this pull request as ready for review March 11, 2022 10:02
fmassot
fmassot reviewed Mar 11, 2022
View reviewed changes
quickwit-serve/src/lib.rs Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 11, 2022
View reviewed changes
quickwit-serve/src/lib.rs Outdated Show resolved Hide resolved
fmassot
fmassot approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you nailed it with this require. It will work well with new services.

Can you check why the formatting of proto auto-generated files changed?

@fulmicoton fulmicoton force-pushed the issue/1160 branch 11 times, most recently from 4a13992 to 1832a9b Compare March 28, 2022 03:25
@fulmicoton fulmicoton enabled auto-merge (squash) March 28, 2022 03:26
@fulmicoton fulmicoton merged commit 02e8455 into main Mar 28, 2022
@fulmicoton fulmicoton deleted the issue/1160 branch March 28, 2022 06:44
This was referenced Mar 29, 2022
Merged
Merged
This was referenced Apr 18, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-exclusive service and rest API for everyone.
2 participants
@fulmicoton @fmassot