Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Fix TLS accept w/ peer certs #535

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

LucioFranco
Copy link
Member

No description provided.

@LucioFranco LucioFranco marked this pull request as ready for review January 15, 2021 16:17
@LucioFranco LucioFranco merged commit 41c51f1 into master Jan 15, 2021
@LucioFranco LucioFranco deleted the lucio/fix-tls-transport branch January 15, 2021 16:59
@brpatel12 brpatel12 mentioned this pull request Jan 16, 2021
@dingelish
Copy link

i don't know where to leave this comment ... but this commit doubled my service's performance. it's really amazing!!!

@dingelish
Copy link

if needed, i can help backport this commit to 0.1, 0.2 and 0.3 and let everyone enjoy it!!!

@LucioFranco
Copy link
Member Author

@dingelish were you using an older version like 0.2 before we attempted to fix this? If so it was doing the handshake slowly. I don't think we should backport but instead have people upgrade. Glad it worked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants