Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Rename server tls config method #73

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Oct 14, 2019

This naming error slipped in as part of #48 - in a ServerTlsConfig you should specify ServerConfig rather than a ClientConfig for rustls

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@LucioFranco LucioFranco changed the title Rename rustls_client_config to rustls_server_config fix(transport): Rename server tls config method Oct 18, 2019
@LucioFranco LucioFranco merged commit 2a4bdb2 into hyperium:master Oct 18, 2019
blittable pushed a commit to blittable/tonic that referenced this pull request Oct 22, 2019
BREAKING CHANGE: `rustls_client_config` for the server has been renamed to `rustls_server_config`.
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants