Command Family #6
Conversation
The Command Family is a transaction family that can exercise all of the operations provided on the TransactionContext in addition to other actions, such as sleeping or marking the transaction as invalid. This family will be used for creating a wide variety of tests, both for correctness and performance of the Transact library. Signed-off-by: Peter Schwarz <[email protected]>
peterschwarz
requested review from
agunde406,
davececchi,
dcmiddle,
jsmitchell,
mastersingh24 and
vaporos
as code owners
| Each entry in the `state_keys` field must be a valid state key (for example, a | ||
| valid address in a Sawtooth merkle trie). | ||
|
|
||
| Note, no validation will occur if the requested state value is actually |
There was a problem hiding this comment.
Is this only to ensure get_state_entries() is working as expected without any panics?
There was a problem hiding this comment.
Missing values do not imply an invalid transaction, though. That's a business logic decision.
| `TransactionContext`'s `delete_state_entries` method. In other words, it will | ||
| only make a single call to the context. | ||
|
|
||
| Each entry in the `state_keys` field must be a valid state key (for example, a |
There was a problem hiding this comment.
How about valid but non-existing key case, so that negative scenario is tested against the Transact read? Or is that scenario left to "force invalid transaction" case?
There was a problem hiding this comment.
valid, but non-existing keys is not a invalid transaction.
|
|
||
| The `receipt_data` field must not be empty. | ||
|
|
||
| ### Sleep |
There was a problem hiding this comment.
I failed to get understanding of why this feature is required or how is this used. Could you please add an example case?
There was a problem hiding this comment.
The value here is for testing timing aspects of the overall system - namely parallel scheduling.
The Command Family is a transaction family that can exercise all of the operations provided on the TransactionContext in addition to other actions, such as sleeping or marking the transaction as invalid. This family will be used for creating a wide variety of tests, both for correctness and performance of the Transact library.