Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages-python): remove obsolete cactus_validator_socketio_iroha #2805

Merged

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Oct 18, 2023

  • Remove python iroha connector since it was superseded by openapi connectors for both iroha V1 and V2.
  • Remove iroha-testnet setup since it was superseded by all-in-one images.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@gitguardian
Copy link

gitguardian bot commented Oct 18, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Elliptic Curve Private Key 483afac packages-python/cactus_validator_socketio_iroha/sample-CA/connector.priv View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Remove python iroha connector since it was superseded by openapi connectors
    for both iroha V1 and V2.
- Remove iroha-testnet setup since it was superseded by all-in-one images.

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the remove_python_iroha_connector_pr branch from 95ab625 to 483afac Compare October 19, 2023 06:32
@petermetz petermetz enabled auto-merge (rebase) October 19, 2023 06:32
@petermetz petermetz merged commit 2482758 into hyperledger-cacti:main Oct 19, 2023
36 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants