-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bulk fix CVEs via dependency resolution overrides 2023-10-23 #2830
build(deps): bulk fix CVEs via dependency resolution overrides 2023-10-23 #2830
Conversation
cc: @RafaelAPB (please see point 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b1bee26
to
63d61d2
Compare
…0-23 1. Couldn't get rid of vulnerable versions in a couple of dependencies because the underlying dependencies have gone ESM only which is a blocker for us at the moment unfortunately. 2. Swapped out the ubiquity TS client to a version of it that I self published onto npm after a full renovation of all of its dependencies. Depends on hyperledger-cacti#2807 (because that one also has a couple of dependency bumps that are needed to eliminate the vulnerabilities) Fixes hyperledger-cacti#2828 Signed-off-by: Peter Somogyvari <[email protected]>
63d61d2
to
d750adc
Compare
This PR/issue depends on:
|
because the underlying dependencies have gone ESM only which is a blocker
for us at the moment unfortunately.
published onto npm after a full renovation of all of its dependencies.
Depends on #2807 (because that one also has a couple of dependency bumps
that are needed to eliminate the vulnerabilities)
Fixes #2828
Fixes #2544
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.