-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2645: Unions in FFI #2837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Oct 6, 2022
appetrosyan
force-pushed
the
iroha2-dev
branch
from
October 7, 2022 07:00
3e49b9b
to
9f0aa0e
Compare
appetrosyan
reviewed
Oct 7, 2022
mversic
force-pushed
the
union_ffi
branch
4 times, most recently
from
October 7, 2022 17:39
937d396
to
fd71cd2
Compare
Erigara
reviewed
Oct 10, 2022
Erigara
reviewed
Oct 10, 2022
mversic
force-pushed
the
union_ffi
branch
5 times, most recently
from
October 11, 2022 07:59
adaeb9d
to
efbdb1f
Compare
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu and
pesterev
as code owners
October 11, 2022 08:03
mversic
force-pushed
the
union_ffi
branch
2 times, most recently
from
October 11, 2022 10:59
31ba785
to
2a7bf5d
Compare
mversic
force-pushed
the
union_ffi
branch
2 times, most recently
from
October 11, 2022 11:34
d701c46
to
fc34be4
Compare
outoftardis
reviewed
Oct 12, 2022
appetrosyan
previously approved these changes
Oct 12, 2022
outoftardis
reviewed
Oct 12, 2022
outoftardis
reviewed
Oct 12, 2022
appetrosyan
force-pushed
the
union_ffi
branch
from
October 12, 2022 12:45
fc34be4
to
75ca92f
Compare
Erigara
reviewed
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2837 +/- ##
==============================================
- Coverage 67.61% 62.72% -4.89%
==============================================
Files 140 168 +28
Lines 26173 29576 +3403
==============================================
+ Hits 17696 18552 +856
- Misses 8477 11024 +2547
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
appetrosyan
force-pushed
the
union_ffi
branch
from
October 12, 2022 14:11
75ca92f
to
af7c90a
Compare
* implement conststring FFI conversion Signed-off-by: Marin Veršić <[email protected]>
appetrosyan
approved these changes
Oct 12, 2022
Erigara
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marin Veršić [email protected]
Description of the Change
ffi_type
prefix toFfiType
helper macro attributesrepr(transparent)
where applicableffi_type(unsafe {robust})
or derive theTransmute
trait manually)ConstString
(out-pointers are still TBD)NonLocal
implsIssue
Closes #2645 #2669 #2800 #2790 #2796
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]