chore!: Modify functionality of commitRoot to use groupToField
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevaundray Wedderburn <[email protected]>
…se groupToField instead of commitment.to_bytes Signed-off-by: Kevaundray Wedderburn <[email protected]>
kevaundray
changed the title
commitRoot to use groupToFieldcommitRoot to use groupToField
kevaundray
commented
Feb 18, 2024
| /// TODO: We can remove this method as its the same as calling commit and then groupToField | ||
| /// TODO: This has not been done because it is a breaking API change, that changes the bindings. | ||
| /// TODO: Once downstream besu-verkle switches to using commit and then groupToField, making this | ||
| /// TODO: method unused, then we can remove it. | ||
| #[no_mangle] | ||
| pub extern "system" fn Java_org_hyperledger_besu_nativelib_ipamultipoint_LibIpaMultipoint_commitRoot( |
There was a problem hiding this comment.
This means that besu-verkle does not need to be modified to make it match the other implementations.
kevaundray
commented
Feb 18, 2024
| }; | ||
|
|
||
| let updated_commitment = ffi_interface::update_commitment_sparse( | ||
| &CONFIG, |
There was a problem hiding this comment.
As of the recent rust-verkle -- most methods just take a CONFIG to make the downstream callers job easier and the API simpler
|
Tests should be failing since hard coded test vectors for commitRoot were not updated |
|
Closing as we don't want to modify commitRoot since mapToScalarField is not invertible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
For the Java library, this will eventually reduce the API surface needed.
commitRootwill essentially become a call tocommitToScalar+groupToField.This issue expands on the rationale: crate-crypto/rust-verkle#86
There are some geth and go-verkle PRs which would be good to merge before merging this (Leaving this as a Draft while those are open)