revert to TransactionDB to resolve 'busy' exception #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
bugfix-3719-rocksdb-busy
branch
from
c62cbfb to
ef7d854
Compare
garyschulte
force-pushed
the
bugfix-3719-rocksdb-busy
branch
from
ef7d854 to
7201d0a
Compare
…ansactionDB Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
bugfix-3719-rocksdb-busy
branch
from
7201d0a to
12156d4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
May 2, 2022
…ansactionDB (hyperledger#3720) Signed-off-by: garyschulte <[email protected]>
|
hi |
|
Yes this has been released. Must have missed it in the changelog! |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ansactionDB (hyperledger#3720) Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Revert to TransactionDB to resolve 'busy' exception from OptimisticTransactionDB.
As I understand it, we originally went to OptimisticTransctionDB in order to support
deleteRange()for our implementation ofRocksDBColumnarKeyBValueStore.clear(). In light of the change to theclearimplementation in #3634, we do not need to use OptimisticTransactionDB.Currently in Draft while testing and while discussing the merits of sticking with OptimisticTransactionDB for locking performance.
Fixed Issue(s)
fixes #3719
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog