address case of block values exceeding long #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
fab-10
pushed a commit
to fab-10/besu
that referenced
this pull request
Feb 1, 2023
* address case of block values exceeding long Signed-off-by: garyschulte <[email protected]>
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Feb 19, 2023
* address case of block values exceeding long Signed-off-by: garyschulte <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* address case of block values exceeding long Signed-off-by: garyschulte <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* address case of block values exceeding long Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: garyschulte [email protected]
PR description
address corner case where long does not fit the calculated block value included in engine_getPayloadV2.
Change BlockValueCalculator to use Wei rather than unnecessarily converting to long (just to later be converted again into a Quantity)
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog