Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-default global max rpc batch size to 1k #5104

Merged
merged 4 commits into from
Feb 17, 2023
Merged

re-default global max rpc batch size to 1k #5104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97c8384
default global max rpc batch size to 1000 for now
garyschulte Feb 17, 2023
9362789
update changelog
garyschulte Feb 17, 2023
5058778
update default engine max batch size, add to toString, equals and has…
garyschulte Feb 17, 2023
d642be2
fix primitive equals comparison
garyschulte Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
## 23.1.0-RC2

### Breaking Changes
- Add a new CLI option to limit the number of requests in a single RPC batch request. Default=1 [#4965](https://github.com/hyperledger/besu/pull/4965)
- Change JsonRpc http service to return the error -32602 (Invalid params) with a 200 http status code
- Besu requires minimum Java 17 and up to build and run [#3320](https://github.com/hyperledger/besu/issues/3320)
- PKCS11 with nss module (PKCS11 based HSM can be used in DevP2P TLS and QBFT PKI) does not work with RSA keys
Expand All @@ -12,6 +11,8 @@ tests are updated to use EC private keys instead of RSA keys.
- Change eth_feeHistory parameter `blockCount` to accept hexadecimal string (was accepting plain integer) [#5047](https://github.com/hyperledger/besu/pull/5047)

### Additions and Improvements
- Default rpc batch request to 1000 [#5104](https://github.com/hyperledger/besu/pull/5104)
- Add a new CLI option to limit the number of requests in a single RPC batch request. [#4965](https://github.com/hyperledger/besu/pull/4965)
- Support for new DATAHASH opcode as part of EIP-4844 [#4823](https://github.com/hyperledger/besu/issues/4823)
- Send only hash announcement for blob transaction type [#4940](https://github.com/hyperledger/besu/pull/4940)
- Add `excess_data_gas` field to block header [#4958](https://github.com/hyperledger/besu/pull/4958)
Expand Down
2 changes: 1 addition & 1 deletion besu/src/main/java/org/hyperledger/besu/cli/DefaultCommandValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public interface DefaultCommandValues {
/** The constant DEFAULT_HTTP_MAX_CONNECTIONS. */
int DEFAULT_HTTP_MAX_CONNECTIONS = 80;
/** The constant DEFAULT_HTTP_MAX_BATCH_SIZE. */
int DEFAULT_HTTP_MAX_BATCH_SIZE = 1;
int DEFAULT_HTTP_MAX_BATCH_SIZE = 1000;
/** The constant DEFAULT_WS_MAX_CONNECTIONS. */
int DEFAULT_WS_MAX_CONNECTIONS = 80;
/** The constant DEFAULT_WS_MAX_FRAME_SIZE. */
Expand Down
9 changes: 6 additions & 3 deletions ...eum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class JsonRpcConfiguration {
public static final int DEFAULT_JSON_RPC_PORT = 8545;
public static final int DEFAULT_ENGINE_JSON_RPC_PORT = 8551;
public static final int DEFAULT_MAX_ACTIVE_CONNECTIONS = 80;
public static final int DEFAULT_MAX_BATCH_SIZE = 1;
public static final int DEFAULT_MAX_BATCH_SIZE = 1000;

private boolean enabled;
private int port;
Expand Down Expand Up @@ -208,6 +208,7 @@ public String toString() {
.add("tlsConfiguration", tlsConfiguration)
.add("httpTimeoutSec", httpTimeoutSec)
.add("maxActiveConnections", maxActiveConnections)
.add("maxBatchSize", maxBatchSize)
.toString();
}

Expand All @@ -228,7 +229,8 @@ public boolean equals(final Object o) {
&& Objects.equals(rpcApis, that.rpcApis)
&& Objects.equals(hostsAllowlist, that.hostsAllowlist)
&& Objects.equals(authenticationCredentialsFile, that.authenticationCredentialsFile)
&& Objects.equals(authenticationPublicKeyFile, that.authenticationPublicKeyFile);
&& Objects.equals(authenticationPublicKeyFile, that.authenticationPublicKeyFile)
&& maxBatchSize == that.maxBatchSize;
}

@Override
Expand All @@ -242,7 +244,8 @@ public int hashCode() {
hostsAllowlist,
authenticationEnabled,
authenticationCredentialsFile,
authenticationPublicKeyFile);
authenticationPublicKeyFile,
maxBatchSize);
}

public int getMaxActiveConnections() {
Expand Down