Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update peer with the first and last block #5659

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Only update peer with the first and last block #5659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ce1eb9
only update peer with the first and last block
pinges Jun 29, 2023
fde8177
check whether there are more than one headers
pinges Jun 30, 2023
5e26887
add a comment
pinges Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...n/java/org/hyperledger/besu/ethereum/eth/manager/task/AbstractGetHeadersFromPeerTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ protected Optional<List<BlockHeader>> processResponse(
BlockHeader prevBlockHeader = firstHeader;
updatePeerChainState(peer, firstHeader);
final int expectedDelta = reverse ? -(skip + 1) : (skip + 1);
BlockHeader header = null;
for (int i = 1; i < headers.size(); i++) {
final BlockHeader header = headers.get(i);
header = headers.get(i);
if (header.getNumber() != prevBlockHeader.getNumber() + expectedDelta) {
// Skip doesn't match, this isn't our data
LOG.debug("header not matching the expected number. Peer: {}", peer);
Expand All @@ -116,6 +117,11 @@ protected Optional<List<BlockHeader>> processResponse(
}
prevBlockHeader = header;
headersList.add(header);
}
// if we have received more than one header we have to update the chain state with the last
// header as well, as the header with the highest block number can be the first or the last
// header.
if (headers.size() > 1) {
updatePeerChainState(peer, header);
}

Expand Down