Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5098: Add additional RpcErrorTypes for invalid parameters #7389

Conversation

Matilda-Clerke
Copy link
Contributor

@Matilda-Clerke Matilda-Clerke commented Jul 28, 2024

PR description

Adds additional RpcErrorTypes to provide extra context around invalid parameters. I recommend starting review with changes in RpcErrorType and InvalidJsonRpcParameters, as these changes lay the foundation for the remainder of the changes.

Fixed Issue(s)

#5098

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10
Copy link
Contributor

fab-10 commented Jul 29, 2024

This PR is good for improving the UX, but a bit too large to be easily reviewed, I suggest to split it in smaller chunks, maybe by grouping similar error type in specific PRs so it is easier to reason about the change.

@Matilda-Clerke
Copy link
Contributor Author

Closing this PR to attempt a more piecemeal approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants