Do not use the sync target to download the headers #7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems straight forward, have you evidence that this is improving the sync? |
jframe
reviewed
Nov 27, 2024
| @@ -99,7 +99,6 @@ private CompletableFuture<List<BlockHeader>> downloadHeaders(final SyncTargetRan | |||
| range.getStart().getNumber(), | |||
| headerRequestSize, | |||
| metricsSystem) | |||
| .assignPeer(range.getSyncTarget()) | |||
There was a problem hiding this comment.
For POS this is safe as the range start block number is used as the minimum required block. For non-pos chains not sure whether this is safe think might be an issue.
If you only skipped this when it's POS then I think it would be better.
There was a problem hiding this comment.
Thinking through this more, it's already possible that other nodes might not have this header and we will fail to download the block. So I think this change is fine.
jframe
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The download headers step should be able to use any peer to download the headers