Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin API - deprecate methods returning optional RPC host/port #8127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jan 16, 2025

In BesuConfiguration methods getRpcHttpHost and getRpcHttpPort (which return Optionals) have been deprecated in favour of getConfiguredRpcHttpHost and getConfiguredRpcHttpPort which return the actual values, which will always be populated since these options have defaults.

Not having to deal unnecessarily with Optionals makes life slightly easier in the plugins.

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla requested a review from jflo January 17, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant