modified base_name to basename #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MintCollie <[email protected]>
|
@ryjones Hi, ry, can you help restart the ci check for this issue? ci/dockercloud (/build_image/dockerhub/latest/common/api-engine) — Your tests failed in Docker Cloud ci/dockercloud (/build_image/dockerhub/latest/common/dashboard) — Your tests failed in Docker Cloud |
|
@yeasy when I look, the builds seem to have been failing for a while even on on master: https://hub.docker.com/repository/docker/hyperledger/cello-dashboard/builds https://hub.docker.com/repository/docker/hyperledger/cello-api-engine/builds I think this is a larger problem than this change. I suggest merging this and fixing master |
yeasy
approved these changes
Apr 7, 2020
yeasy
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran into an issue with the container failing to start.
I believe its because
base_nameis deprecated and supposed to bebasenamebased off this stack overflow postcould you please test and verify?