fix(worker): fix eq filter for non-index predicates. (#6986)

* fix eq function with non indexed predicate * remove tests for between function
hypermodeinc · Nov 25, 2020 · 54ef639 · 54ef639
1 parent c8d2798
commit 54ef639
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 3 deletions.
diff --git a/query/query0_test.go b/query/query0_test.go
@@ -2936,6 +2936,30 @@ func TestFilterNonIndexedPredicate(t *testing.T) {
 	}
 }
 
+func TestEqFilterWithoutIndex(t *testing.T) {
+	test := struct {
+		name   string
+		query  string
+		result string
+	}{
+		`Test eq filter on Non Indexed Predicate`,
+		`
+		{
+			me(func: type(CarModel)) @filter(eq(year,2008,2009)){
+				make
+				model
+				year
+			}
+		}
+		`,
+		`{"data":{"me":[{"make":"Ford","model":"Focus","year":2008},{"make":"Ford","model":"Focus","year":2009},{"make":"Toyota","model":"Prius","year":2009}]}}`,
+	}
+
+	js := processQueryNoErr(t, test.query)
+	require.JSONEq(t, js, test.result)
+
+}
+
 var client *dgo.Dgraph
 
 func TestMain(m *testing.M) {

diff --git a/worker/task.go b/worker/task.go
@@ -451,10 +451,20 @@ func (qs *queryState) handleValuePostings(ctx context.Context, args funcArgs) er
 					if val, err = types.Convert(val, srcFn.atype); err != nil {
 						return err
 					}
-					if types.CompareVals(srcFn.fname, val, srcFn.ineqValue) {
-						uidList.Uids = append(uidList.Uids, q.UidList.Uids[i])
-						break
+					switch srcFn.fname {
+					case "eq":
+						for _, eqToken := range srcFn.eqTokens {
+							if types.CompareVals(srcFn.fname, val, eqToken) {
+								uidList.Uids = append(uidList.Uids, q.UidList.Uids[i])
+								break
+							}
+						}
+					default:
+						if types.CompareVals(srcFn.fname, val, srcFn.eqTokens[0]) {
+							uidList.Uids = append(uidList.Uids, q.UidList.Uids[i])
+						}
 					}
+
 				} else {
 					vl.Values = append(vl.Values, newValue)
 				}