fix(postingList): Acquire lock before reading the cached posting list (…

…#7632) The GetNew function may fetch the posting list from the cache. This cached copy of the posting list might be still in use at other places and so we need to acquire a lock on it before we read it. Co-authored-by: NamanJain8 <[email protected]>
hypermodeinc · Apr 8, 2021 · bdfce25 · bdfce25
1 parent 91d8f4e
commit bdfce25
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/posting/mvcc.go b/posting/mvcc.go
@@ -437,12 +437,14 @@ func getNew(key []byte, pstore *badger.DB, readTs uint64) (*List, error) {
 				key:   key,
 				plist: l.plist,
 			}
+			l.RLock()
 			if l.mutationMap != nil {
 				lCopy.mutationMap = make(map[uint64]*pb.PostingList, len(l.mutationMap))
 				for ts, pl := range l.mutationMap {
 					lCopy.mutationMap[ts] = proto.Clone(pl).(*pb.PostingList)
 				}
 			}
+			l.RUnlock()
 			return lCopy, nil
 		}
 	}