Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow start in embedded/library mode #1246

Closed
tzdybal opened this issue Jul 25, 2017 · 6 comments
Closed

Slow start in embedded/library mode #1246

tzdybal opened this issue Jul 25, 2017 · 6 comments
Assignees
@tzdybal
Labels
kind/bug Something is broken.
Milestone
v0.8.1

Comments

@tzdybal
Copy link
Contributor

tzdybal commented Jul 25, 2017 •
edited by manishrjain
Loading

First start of application using Dgraph as library is fast. But all the latter starts are very slow - there is a lag of about 15s before queries start to work.
@tzdybal tzdybal added the kind/bug Something is broken. label Jul 25, 2017
@tzdybal tzdybal added this to the v0.9Maybe milestone Jul 25, 2017
@tzdybal tzdybal self-assigned this Jul 25, 2017
@manishrjain
Copy link
Contributor

Could be because we're busy loading up all the pending writes, since the last successful Raft snapshot. Did you close cleanly?

@manishrjain manishrjain modified the milestones: v0.9Maybe, v0.8.1 Jul 26, 2017
@tzdybal
Copy link
Contributor Author

tzdybal commented Jul 26, 2017

The problem is following: if we start from scratch, we force raft election immediately after starting raft.
After restarting raft, we have to wait 9 or 10 seconds/ticks for election.
And client code sleeps after each error in exponential manner. 1+2+4+8=15s -after that client can execute.

@manishrjain
Copy link
Contributor

@srh had a plan to change the ticks to 10ms. In that case, we can do elections faster.

@srh
Copy link

srh commented Jul 27, 2017

The ticks are 20 ms as of sam/tickrate which is in a PR now.

@tzdybal
Copy link
Contributor Author

tzdybal commented Jul 27, 2017

I'll merge/cherry-pick your PR and test your changes.

@tzdybal
Copy link
Contributor Author

tzdybal commented Jul 28, 2017

@srh your change solves the problem. I'm closing the issue.

@tzdybal tzdybal closed this as completed Jul 28, 2017
@manishrjain manishrjain added the kind/bug Something is broken. label Mar 22, 2018
jarifibrahim pushed a commit that referenced this issue Mar 16, 2020
Update badger to commit 91c31ebe8c22 (#4935)
cc3c5cd 
Important changes
```
 - Changes to overlap check in compaction.
 - Remove 'this entry should've been caught' log.
 - Changes to write stalling on levels 0 and 1.
 - Compression is disabled by default in Badger.
 - Bloom filter caching in a separate ristretto cache.
 - Compression/Encryption in background.
 - Disable cache by default in badger.
```

The following new changes are being added from badger
`git log ab4352b00a17...91c31ebe8c22`

```
91c31eb Disable cache by default (#1257)
eaf64c0 Add separate cache for bloom filters (#1260)
1bcbefc Add BypassDirLock option (#1243)
c6c1e5e Add support for watching nil prefix in subscribe API (#1246)
b13b927 Compress/Encrypt Blocks in the background (#1227)
bdb2b13 fix changelog for v2.0.2 (#1244)
8dbc982 Add Dkron to README (#1241)
3d95b94 Remove coveralls from Travis Build(#1219)
5b4c0a6 Fix ValueThreshold for in-memory mode (#1235)
617ed7c Initialize vlog before starting compactions in db.Open (#1226)
e908818 Update CHANGELOG for Badger 2.0.2 release. (#1230)
bce069c Fix int overflow for 32bit (#1216)
e029e93 Remove ExampleDB_Subscribe Test (#1214)
8734e3a Add missing package to README for badger.NewEntry (#1223)
78d405a Replace t.Fatal with require.NoError in tests (#1213)
c51748e Fix flaky TestPageBufferReader2 test (#1210)
eee1602 Change else-if statements to idiomatic switch statements. (#1207)
3e25d77 Rework concurrency semantics of valueLog.maxFid (#1184) (#1187)
4676ca9 Add support for caching bloomfilters (#1204)
c3333a5 Disable compression and set ZSTD Compression Level to 1 (#1191)
0acb3f6 Fix L0/L1 stall test (#1201)
7e5a956 Support disabling the cache completely. (#1183) (#1185)
82381ac Update ristretto to version  8f368f2 (#1195)
3747be5 Improve write stalling on level 0 and 1
5870b7b Run all tests on CI (#1189)
01a00cb Add Jaegar to list of projects (#1192)
9d6512b Use fastRand instead of locked-rand in skiplist (#1173)
2698bfc Avoid sync in inmemory mode (#1190)
2a90c66 Remove the 'this entry should've caught' log from value.go (#1170)
0a06173 Fix checkOverlap in compaction (#1166)
0f2e629 Fix windows build (#1177)
03af216 Fix commit sha for WithInMemory in CHANGELOG. (#1172)
23a73cd Update CHANGELOG for v2.0.1 release. (#1181)
465f28a Cast sz to uint32 to fix compilation on 32 bit (#1175)
ea01d38 Rename option builder from WithInmemory to WithInMemory. (#1169)
df99253 Remove ErrGCInMemoryMode in CHANGELOG. (#1171)
8dfdd6d Adding changes for 2.0.1 so far (#1168)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzdybal tzdybal

Labels
kind/bug Something is broken.
Milestone
v0.8.1
Development

No branches or pull requests
3 participants
@srh @tzdybal @manishrjain