Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty predicate/edge names crash db #1381

Closed
mekanoe opened this issue Aug 30, 2017 · 1 comment
Closed

Empty predicate/edge names crash db #1381

mekanoe opened this issue Aug 30, 2017 · 1 comment
Assignees
@pawanrawal
Labels
kind/bug Something is broken.

Comments

@mekanoe
Copy link

mekanoe commented Aug 30, 2017 •
edited by manishrjain
Loading

Given this example, you can create Edges with empty strings as names, and it crashes the DB, and crashes on every subsequent start until data is reset.

c := client.NodeBlank("somename")
e := c.Edge("")
e.ConnectTo(c)

// save it in some way
req := client.Req{}
req.Set(e)
client.Run(context.Background(), req)
@pawanrawal pawanrawal self-assigned this Aug 30, 2017
@pawanrawal pawanrawal added the kind/bug Something is broken. label Aug 30, 2017
pawanrawal pushed a commit that referenced this issue Aug 31, 2017
Fixes for #1381 and #1382
ed87514
pawanrawal pushed a commit that referenced this issue Aug 31, 2017
Fixes for #1381 and #1382
ac0c07c
@pawanrawal
Copy link
Contributor

Thanks for the report @kayteh. Fixed with ac0c07c.

@manishrjain manishrjain added the kind/bug Something is broken. label Mar 21, 2018
jarifibrahim pushed a commit that referenced this issue Jul 11, 2020
Update badger to v20.0.7-rc1
07e288e 
This commit brings following new changes from badger
This commit also disable conflict detection in badger to save memory.

```
0dfb8b4 Changelog for v20.07.0 (#1411)
03ba278 Add missing changelog for v2.0.3 (#1410)
6001230 Revert "Compress/Encrypt Blocks in the background (#1227)" (#1409)
800305e Revert "Buffer pool for decompression (#1308)" (#1408)
63d9309 Revert "fix: Fix race condition in block.incRef (#1337)" (#1407)
e0d058c Revert "add assert to check integer overflow for table size (#1402)" (#1406)
d981f47 return error if the vlog writes exceeds more that 4GB. (#1400)
7f4e4b5 add assert to check integer overflow for table size (#1402)
8e896a7 Add a contribution guide (#1379)
b79aeef Avoid panic on multiple closer.Signal calls (#1401)
717b89c Enable cross-compiled 32bit tests on TravisCI (#1392)
09dfa66 Update ristretto to commit f66de99 (#1391)
509de73 Update head while replaying value log (#1372)
e013bfd Rework DB.DropPrefix (#1381)
3042e37 pre allocate cache key for the block cache and the bloom filter cache (#1371)
675efcd Increase default valueThreshold from 32B to 1KB (#1346)
158d927 Remove second initialization of writech in Open (#1382)
d37ce36 Tests: Use t.Parallel in TestIteratePrefix tests  (#1377)
3f4761d Force KeepL0InMemory to be true when InMemory is true (#1375)
dd332b0 Avoid panic in filltables() (#1365)
c45d966 Fix assert in background compression and encryption. (#1366)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanrawal pawanrawal

Labels
kind/bug Something is broken.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mekanoe @manishrjain @pawanrawal