Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gql lexer cannot parse language name along with script #1427

Closed
windoze opened this issue Sep 8, 2017 · 1 comment
Closed

gql lexer cannot parse language name along with script #1427

windoze opened this issue Sep 8, 2017 · 1 comment
Assignees
Labels
kind/bug Something is broken.
Milestone

Comments

@windoze
Copy link

windoze commented Sep 8, 2017

I.e. this will not return any result

mutation {
  set {
    <1> <text> "This is a colour"@en-us .
  }
}

{
  q(func: uid(1)) {
    text@en-us
  }
}

But this will return result correctly

mutation {
  set {
    <1> <text> "This is a colour"@en .
  }
}
{
  q(func: uid(1)) {
    text@en
  }
}

Looks like gql parser has some issues to parse language tag with '-' in the middle.

@windoze
Copy link
Author

windoze commented Sep 8, 2017

I've add a hack in #1428, which allows queries to use underscores, i.e. "en_us", while mutations and RDF are still using "-".

@pawanrawal pawanrawal added the kind/bug Something is broken. label Sep 13, 2017
@pawanrawal pawanrawal added this to the v0.8.2 milestone Sep 13, 2017
@pawanrawal pawanrawal self-assigned this Sep 13, 2017
pawanrawal pushed a commit that referenced this issue Sep 15, 2017
pawanrawal pushed a commit that referenced this issue Sep 18, 2017
…s set implicitly.

2. Run query without debug flag when user clicks on JSON.
3. Fix #1427 and #1444.
@manishrjain manishrjain added the kind/bug Something is broken. label Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken.
Development

No branches or pull requests

3 participants